Skip to content

Search box url detection and open link feature #1881#1915

Merged
Lissy93 merged 45 commits intoLissy93:masterfrom
aspenyang:opt1-search
Mar 10, 2026
Merged

Search box url detection and open link feature #1881#1915
Lissy93 merged 45 commits intoLissy93:masterfrom
aspenyang:opt1-search

Conversation

@aspenyang
Copy link
Contributor

@aspenyang aspenyang commented Sep 7, 2025 •
edited by pull-request-badge bot
Loading

aspenyang Large aspenyang /opt1-search → Lissy93/dashy Commits: 43 | Files Changed: 12 | Additions: 696 Label Unchecked Tasks Powered by Pull Request Badge

Category:

Feature

Overview

Work in Progress – Opening this PR to gather feedback.
Implements the the URL detection / "go to link" feature and adds a toggle for default web search behavior.

Current behavior:

  • Pressing Enter on a detected URL opens the link.
  • Web search can be enabled/disabled via conf.yml (default on launch) and a runtime UI toggle.

Issue Number (if applicable) #1881

New Vars (if applicable)

  • disableWebSearch in conf.yml: controls default web search behavior on Dashy launch.
  • A setting button besides the search bar:
    • a runtime option to toggle the web search feature
    • a runtime option to toggle the "go to link" feature

Screenshot (if applicable)

  • The web search toggle configuration in conf.yml UI:
    web_search_toggle_conf_edited
  • The search bar behavior setting button:
    search_settings_button_edited
  • Runtime toggles for the web search feature and the url detection/open link feature
    search_settings

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

aspenyang added 14 commits August 10, 2025 20:24
@netlify
Copy link

netlify bot commented Sep 7, 2025 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 958f82f
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/69b00b9a94c3070009a75261
😎 Deploy Preview https://deploy-preview-1915--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aspenyang aspenyang mentioned this pull request Sep 7, 2025
Closed
@aspenyang
feat(search): add field-specific advanced tile filtering
559f5d9 
Adds searchTilesWithFields(allTiles, searchTerm, fieldSelection) to enable advanced search constrained to selected fields.
@aspenyang
fix(search): respect enabled fields when determining exact matches Body
bf84199 
feat(search): add field-aware exact match section grouped by original section Body
@aspenyang
Copy link
Contributor Author

aspenyang commented Sep 30, 2025

New Features: Advanced Search Functionality

  • Advanced Search Panel: Users can enable advanced search and select which fields (title, description, provider, URL, tags, domain) to search from.
  • Exact Match Block: When advanced search is enabled, exact matches are visually highlighted in a dedicated section for quick access.
  • Force Web Search (only accessible when web search enabled): Option to trigger a web search using Ctrl/Cmd+Enter, even when a web link is detected.

New Vars

  • Search Settings Button
    • Provides a runtime option to enable Advanced Search, allowing users to filter by specific fields.

Screenshots:

Advanced search panel

  • User can select from six fields to restrict search range
  • User can toggle "ctrl/cmd + enter" to enforce web search (when web search enabled)
    advanced_search_edited

Exact Match Section

  • When searching in advanced mode, a new "Exact Match" block will show up if there are exact matches
  • Selected item in "Exact Search" is highlighted, user can press "enter" to open the selected item
  • User can use "left" and "right" arrow key to change selected item
    exact_match_edited

@aspenyang aspenyang marked this pull request as ready for review November 16, 2025 21:22
@aspenyang aspenyang requested a review from Lissy93 as a code owner November 16, 2025 21:22
@Lissy93
⏪️ Resets conf.yml to og state
8c210b8 
Updated the configuration file to change theme and structure.
@Lissy93
🗑️ Delete .tsbuildinfo
76f0122
@Lissy93 Lissy93 changed the title Work in Progress: Search box url detection and open link feature #1881 Search box url detection and open link feature #1881 Nov 16, 2025
Lissy93
Lissy93 reviewed Nov 16, 2025
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I'll give this a proper review, and get it merged tomorrow :)

Lissy93
Lissy93 approved these changes Mar 10, 2026
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @aspenyang, apologies for the very long delay on this.

I really liked your core idea! Will be very useful, especially in the context of a browser startpage.

But I am going to need to come back to re-implementing your advanced search UI toggles, as for now I worry that they add some maintenance overhead, which needs some more thought.

So, for now I have made some updates to your PR, which simplify things quite a lot, and basically just cover off the "URL entered" use case.

The version I will merge has this functionality is:
A new openUrlsDirectly (under appConfig.webSearch), which if set to true will: detect a search string which is in the format of a valid-looking URL. And then navigate directly to that URL when enter is pressed (bypassing the search).

In the meantime, I recommend you run your own fork, so that you can use your full version. Because (for now) that UI implementation is going to add too much maintenance overhead.

I hope that's okay with you

@Lissy93 Lissy93 merged commit c2b2eb5 into Lissy93:master Mar 10, 2026
11 of 12 checks passed
@aspenyang
Copy link
Contributor Author

aspenyang commented Mar 11, 2026

Hi @Lissy93, thanks for the kind feedback and for taking the time to review and refine the PR! I’m glad the direct URL detection feature will be included. I completely understand the concerns about maintenance overhead and really appreciate the feedback on my work. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aspenyang @Lissy93